remove duplicated file name access and use StringBuilder to insert in WebServerPortFileWriter #42411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@choi-hyeseong Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@choi-hyeseong Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: task
philwebb
pushed a commit
that referenced
this pull request
Sep 23, 2024
Update `WebServerPortFileWriter` so that `file.getName()` is only called once. See gh-42411
philwebb
added a commit
that referenced
this pull request
Sep 23, 2024
|
Thanks very much @choi-hyeseong, I wasn't aware that calls to |
|
Thank you for considering my PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The File.getName() method always slice the path to get the name. so, it's not cached
It doesn't have a huge impact, but it's not efficient, so i fixed it :)
Also, the original code was truncating the extension from the filename, adding the namespace, and then putting the extension back together again, but i modified the code to be cleaner by using StringBuilder to do the insertion.
This change passed the test (WebServerPortFileWriterTests.java)